Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

@prachi00 prachi00 commented Dec 26, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

Screenshot 2021-12-26 at 7 22 57 PM

Screenshot 2021-12-26 at 7 23 13 PM

Screenshot 2021-12-26 at 7 25 35 PM

@netlify
Copy link

netlify bot commented Dec 26, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 964e736

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61c9c2f62fc45000089b9b1c

😎 Browse the preview: https://deploy-preview-1605--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

@prachi00 gallery has "buy now" which should be changed :)
image

@prachi00
Copy link
Member Author

@prachi00 gallery has "buy now" which should be changed :) image

@yangwao yeah missed this one, added now.

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

Not sure where is an error if service worker push old data even after flushed application still see old one
Build seems successfull.
image

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

oh I see, there is even more complicated error, like service worker on that toast receive a new update, but won't update running runtime, that seems badass

image

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

@yangwao yangwao merged commit 90a3d3d into kodadot:main-nuxt Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add YOLO to user preference

2 participants