-
-
Notifications
You must be signed in to change notification settings - Fork 365
#1543 Use interpolation expressions instead of the v-html attribute #1586
Conversation
|
✔️ Deploy Preview for koda-nuxt ready! 🔨 Explore the source changes: 7fd1c97 🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61c959f4be4d570007f924e6 😎 Browse the preview: https://deploy-preview-1586--koda-nuxt.netlify.app |
kkukelka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some spelling errors
|
is it good to go? |
@yangwao it was a repetition, the original file is in a different folder, this one is not getting used anywhere |
|
@roiLeo Have fixed this |
For test case, change |
@roiLeo How are you opening the
|
|
|
@roiLeo The logic for this seems fine to me, can you also once take a look and see if something seems off? Not able to figure out why its working incorrectly |
roiLeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it seems to work. I find the logic difficult to understand but we can improve it later.
Note: I found bugs with the numbers displayed (empty buys columns, floor price sorting...)
Added comments to make it easier to understand |
|
Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x557ab67e55aafb5bd76d2fa53145540d576313eebae6727f95d6e29ba66ec2ba Let’s grab another issue and get rewarded! |


Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.
PR type
Before submitting Pull Request, please make sure:
Optional
What's new?
v-htmlattribute #1543Removed one useless FAQ file that was not being used anywhere, it also had a v-html tag
the real FAQ file still has one, since that requires parsing the text, I don't think v-html would be an issue here, but if we were to remove it, we will have to parse it through
domParser, let me know if we want to go this way.Removed it from series-insights
Had issue bounty label ?
Payout
Community participation
Screenshot