Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

@prachi00 prachi00 commented Dec 23, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

  • PR closes (JS-0693) Use interpolation expressions instead of the v-html attribute #1543
  • [ ]
    Removed one useless FAQ file that was not being used anywhere, it also had a v-html tag
    the real FAQ file still has one, since that requires parsing the text, I don't think v-html would be an issue here, but if we were to remove it, we will have to parse it through domParser, let me know if we want to go this way.
    Removed it from series-insights

Had issue bounty label ?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@netlify
Copy link

netlify bot commented Dec 23, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 7fd1c97

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61c959f4be4d570007f924e6

😎 Browse the preview: https://deploy-preview-1586--koda-nuxt.netlify.app

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some spelling errors

@yangwao
Copy link
Member

yangwao commented Dec 25, 2021

is it good to go?
Why was FAQ deleted 👀

@prachi00
Copy link
Member Author

is it good to go? Why was FAQ deleted 👀

@yangwao it was a repetition, the original file is in a different folder, this one is not getting used anywhere

@roiLeo
Copy link
Contributor

roiLeo commented Dec 26, 2021

Hey, '---' with red text isn't fixed yeet, see my review.
Screenshot 2021-12-26 at 09-27-59 nft-gallery-nuxt

@prachi00
Copy link
Member Author

Hey, '---' with red text isn't fixed yeet, see my review. Screenshot 2021-12-26 at 09-27-59 nft-gallery-nuxt

@roiLeo Have fixed this

@roiLeo
Copy link
Contributor

roiLeo commented Dec 26, 2021

@roiLeo Have fixed this

Screenshot 2021-12-26 at 11-43-08 nft-gallery-nuxt

For test case, change collectionSeriesList.graphql

  collectionEntities(
    first: 9
    offset: 0
    filter: { issuer: { notIn: $denyList } }
  ) {

@prachi00
Copy link
Member Author

prachi00 commented Dec 26, 2021

@roiLeo Have fixed this

Screenshot 2021-12-26 at 11-43-08 nft-gallery-nuxt

For test case, change collectionSeriesList.graphql

  collectionEntities(
    first: 9
    offset: 0
    filter: { issuer: { notIn: $denyList } }
  ) {

@roiLeo How are you opening the

@roiLeo Have fixed this

Screenshot 2021-12-26 at 11-43-08 nft-gallery-nuxt

For test case, change collectionSeriesList.graphql

  collectionEntities(
    first: 9
    offset: 0
    filter: { issuer: { notIn: $denyList } }
  ) {

@prachi00
Copy link
Member Author

first: 9
offset: 0
filter: { issuer: { notIn: $denyList } }

@roiLeo Have fixed this

Screenshot 2021-12-26 at 11-43-08 nft-gallery-nuxt
For test case, change collectionSeriesList.graphql

  collectionEntities(
    first: 9
    offset: 0
    filter: { issuer: { notIn: $denyList } }
  ) {

@prachi00
Copy link
Member Author

@roiLeo The logic for this seems fine to me, can you also once take a look and see if something seems off? Not able to figure out why its working incorrectly

@prachi00
Copy link
Member Author

@roiLeo The logic for this seems fine to me, can you also once take a look and see if something seems off? Not able to figure out why its working incorrectly

@roiLeo changed the logic a little bit, seems to work fine now

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it seems to work. I find the logic difficult to understand but we can improve it later.

Note: I found bugs with the numbers displayed (empty buys columns, floor price sorting...)

@prachi00
Copy link
Member Author

Well, it seems to work. I find the logic difficult to understand but we can improve it later.

Added comments to make it easier to understand

@yangwao
Copy link
Member

yangwao commented Dec 27, 2021

@yangwao yangwao merged commit 67f08c7 into kodadot:main-nuxt Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(JS-0693) Use interpolation expressions instead of the v-html attribute

5 participants