This repository was archived by the owner on Dec 5, 2025. It is now read-only.
Statemine Integration for KodaDot #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A reviewer left a comment:
Browser metadata |
Contributor
HEY! That's me. |
Member
Author
Should be fixed in 92bdea8 |
Member
|
/giphy whats happening here |
Contributor
|
|
Member
# Conflicts: # nuxt.config.js
Member
|
/giphy merging from mobile while driving |
Contributor
|
|
roiLeo
reviewed
Dec 23, 2021
Contributor
roiLeo
left a comment
roiLeo
left a comment
There was a problem hiding this comment.
Well we got big update over here!
Some things I noted:
<div class="box">oncomponnents/unique/could be added to layout instead of adding it on each file- Are mixins required? Will it interfere with the rendering? Does it increase loading onn some component?
- One Landing component for multiple entry point? I thought the design would change from selected parachain
Comment on lines
+2
to
+3
| <div class="columns"> | ||
| <div class="column is-6 is-offset-3"> |
Contributor
There was a problem hiding this comment.
missing layout on this file
| > | ||
| <Identity :address="props.row.From" inline noOverflow /> | ||
| </nuxt-link> | ||
| </router-link> |
Contributor
There was a problem hiding this comment.
Suggested change
| </router-link> | |
| </nuxt-link> |
| v-slot="props" | ||
| > | ||
| <nuxt-link | ||
| <router-link |
Contributor
There was a problem hiding this comment.
Suggested change
| <router-link | |
| <nuxt-link |
Comment on lines
+110
to
+111
| buy: any[], | ||
| list: any[], |
Contributor
There was a problem hiding this comment.
Suggested change
| buy: any[], | |
| list: any[], | |
| buy: [Date, number][], | |
| list: [Date, number][], |
|
|
||
| <script lang="ts" > | ||
| import { Component, Prop, Vue } from 'nuxt-property-decorator' | ||
| import { Component, Prop, Vue } from 'vue-property-decorator' |
Contributor
There was a problem hiding this comment.
Suggested change
| import { Component, Prop, Vue } from 'vue-property-decorator' | |
| import { Component, Prop, Vue } from 'nuxt-property-decorator' |
| @@ -0,0 +1,77 @@ | |||
| <template> | |||
Contributor
There was a problem hiding this comment.
- Indentation
- What does this component do?
Comment on lines
+130
to
+145
| get fileType() { | ||
| return resolveMedia(this.vFile?.type) | ||
| } | ||
| get secondaryFileVisible() { | ||
| const fileType = this.fileType | ||
| return ![MediaType.UNKNOWN, MediaType.IMAGE].some(t => t === fileType) | ||
| } | ||
| get hasPrice() { | ||
| return Number(this.vPrice) | ||
| } | ||
| get clickableMax() { | ||
| return (this.max || Infinity) - this.alreadyMinted | ||
| } |
Member
|
/giphy can we be one |
Contributor
|
|
Member
|
will it change wave |
Member
|
y |
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statemine is here!
Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!
PR type
Before submitting this PR, please make sure:
What's new? (may be part of changelog)