Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@codiini
Copy link
Contributor

@codiini codiini commented Dec 16, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@netlify
Copy link

netlify bot commented Dec 16, 2021

❌ Deploy Preview for koda-nuxt failed.

🔨 Explore the source changes: 2acea37

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61bb68a2d91b1300089e468b

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 to go:

➜  nft-gallery git:(main-nuxt) ✗ find .  -regex ".*/_id.vue"         
./pages/rmrk/collection/_id.vue
./pages/rmrk/gallery/_id.vue
./pages/rmrk/u/_id.vue
./pages/rmrk/pack/_id.vue
./pages/rmrk/detail/_id.vue
./pages/index.vue

@codiini codiini requested review from vikiival December 16, 2021 14:53
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you commit the suggestions? 🥺

codiini and others added 2 commits December 16, 2021 17:25
@codiini
Copy link
Contributor Author

codiini commented Dec 16, 2021

@vikiival Done!

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangwao
Copy link
Member

yangwao commented Dec 17, 2021

Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/

@yangwao yangwao merged commit 8224d23 into kodadot:main-nuxt Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid component name

4 participants