Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR
nav-feature.mov

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

  1. Implement Navigation Component to go to next and previous items in collection
  2. Collection Ids are saved in store so request has to be made only once for currently viewed collection
  3. nav icons are always shown on mobile, on desktop only on hover
  4. since buttons are tagged as nuxt-links, prefetching should happen automagically https://nuxtjs.org/announcements/introducing-smart-prefetching/

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 922fde6

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61bb8fc07e61d80007942db3

😎 Browse the preview: https://deploy-preview-1535--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 16, 2021

Works well here on mobile!

21-12-16-10-12-30.mp4

@yangwao yangwao requested a review from roiLeo December 16, 2021 09:13
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On store/history.ts I would prefer writing mutations like constants to make a difference with actions.

@kkukelka kkukelka requested a review from roiLeo December 16, 2021 10:43
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See new comment for css solution

@kkukelka
Copy link
Member Author

See new comment for css solution

@roiLeo point taken 😅 I apologize for this inconvenience... not too familiar with bulma yet

@kkukelka kkukelka requested a review from roiLeo December 16, 2021 15:28
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@yangwao
Copy link
Member

yangwao commented Dec 16, 2021

amazing conversations!
thanks, @marsic3 for reviewing, you can help us chop a few issues if you'd like to!

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x504a92959fc8f493070052adc2d8d94915d545a96eeecf2194c58c42996148ec

Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/

@yangwao yangwao merged commit 72d8b5e into kodadot:main-nuxt Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next and previous chevrons on NFT item detail

4 participants