Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@ocvlgmz
Copy link
Contributor

@ocvlgmz ocvlgmz commented Dec 14, 2021

Checked for erroneous term translation and offered a more appropriate French version.
Corrected couple of html formatting to prevent potential issues.
I'll check other json file for further translation improvements in English, French and Spanish.

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

Checked for erroneous term translation and offered a more appropriate French version. 
Corrected couple of html formatting to prevent potential issues.
I'll check other json file for further translation improvements in English, French and Spanish.
@netlify
Copy link

netlify bot commented Dec 14, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 918c5b4

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61bde99b2f45680007e8734e

😎 Browse the preview: https://deploy-preview-1525--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 14, 2021

maybe @roiLeo can verify 👀

@roiLeo roiLeo self-assigned this Dec 15, 2021
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!
I remember that the French translation of Mint seemed strange to me, now it's better.
I've added some comments, you can directly click on "Commit suggestion" to integrate them

Copy link
Contributor Author

@ocvlgmz ocvlgmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the comments, hope it's helpful.

@yangwao
Copy link
Member

yangwao commented Dec 15, 2021

I approved for deployment, so you could see it live 3-4 minutes once you commit on your developer preview https://deploy-preview-1525--koda-nuxt.netlify.app/

let's stick to proper grammar

Co-authored-by: roiLeo <[email protected]>
@yangwao
Copy link
Member

yangwao commented Dec 16, 2021

can we merge

@roiLeo
Copy link
Contributor

roiLeo commented Dec 16, 2021

Only missing "MD" replacement and it will be ready to go

@yangwao
Copy link
Member

yangwao commented Dec 17, 2021

@LatinSoul let's finish this one and post your KSM address as well so you can receive reward for your effort!

@ocvlgmz
Copy link
Contributor Author

ocvlgmz commented Dec 17, 2021

@LatinSoul let's finish this one and post your KSM address as well so you can receive reward for your effort!
Thnks @yangwao I'll be happy to do more as soon as I ll get a better understanding of the code here. In the meantime, here is my KSM address 0xd42b49f478c3b63b5bb9bf82fdc89d2c8fb9ca8a as suggested. :)

@yangwao
Copy link
Member

yangwao commented Dec 17, 2021

0xd42b49f478c3b63b5bb9bf82fdc89d2c8fb9ca8a

hey check how to create your KSM address, you've posted public key of your address https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address

@ocvlgmz
Copy link
Contributor Author

ocvlgmz commented Dec 17, 2021

0xd42b49f478c3b63b5bb9bf82fdc89d2c8fb9ca8a

hey check how to create your KSM address, you've posted public key of your address https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address

Ok done. I installed the Polkadot browser extension and created an new account as well as got the KSM address (using Kusama relay chain) : FZX9M9F86CjEGRhLAj8SJxMxvKtW2NaVRCWEEkoAXTBykXs
Is this ok?

@yangwao
Copy link
Member

yangwao commented Dec 17, 2021

Only missing "MD" replacement and it will be ready to go

@LatinSoul let's fix this and sure we can merge this one!

@ocvlgmz
Copy link
Contributor Author

ocvlgmz commented Dec 17, 2021

Only missing "MD" replacement and it will be ready to go

@LatinSoul let's fix this and sure we can merge this one!

Is there any action I left for me to do to help with this PR?

@yangwao
Copy link
Member

yangwao commented Dec 18, 2021

Is there any action I left for me to do to help with this PR?

I'm just referring to what I've seen in the upper comments. If it's solved, let's merge it then!

image

@yangwao
Copy link
Member

yangwao commented Dec 19, 2021

@yangwao yangwao merged commit d8fe33f into kodadot:main-nuxt Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants