Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@rhaicode
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

http://somup.com/crl2fL0HUU
Capture

@netlify
Copy link

netlify bot commented Dec 14, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: e09a58f

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61bdbefac6045900084ab510

😎 Browse the preview: https://deploy-preview-1520--koda-nuxt.netlify.app

@vikiival
Copy link
Member

Please use linter, looks like yours made a ton of changes into nuxt.config.js

@yangwao
Copy link
Member

yangwao commented Dec 14, 2021

Please use linter, looks like yours made a ton of changes into nuxt.config.js

yeah @rhaicode let's use linter and we can merge, it's def nicer than basic one! :)

@roiLeo
Copy link
Contributor

roiLeo commented Dec 14, 2021

Hey! IMO, you should change the .html to a .vue component as seen in Nuxt doc

Some of the css can be removed and replaced by Bulma helpers class

@rhaicode
Copy link
Contributor Author

rhaicode commented Dec 14, 2021

Hello @vikiival , since we have ssr:false, it is not applicable. Therefore, this is the Nuxt doc (https://nuxtjs.org/examples/loading/customize-loading-indicator) that I have followed where in we have to use loadingIndicator.

More about loadingIndicator : https://nuxtjs.org/docs/configuration-glossary/configuration-loading-indicator/ and head over to 'Custom indicators'. It will refer you to Nuxt's built-in source code that are using .html instead

@yangwao
Copy link
Member

yangwao commented Dec 16, 2021

hey let's add this one "folding square" from spinkit https://tobiasahlin.com/spinkit/
and we are good to go! :)

Screen.Recording.2021-12-16.at.16.18.47.mov

@rhaicode
Copy link
Contributor Author

Hi @yangwao , what do you think now of the new preloader?

@yangwao
Copy link
Member

yangwao commented Dec 19, 2021

@yangwao yangwao merged commit 8613ec1 into kodadot:main-nuxt Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change preloader on beta

4 participants