Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 78518c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61ba3160682b4d000834c0d1

😎 Browse the preview: https://deploy-preview-1484--koda-nuxt.netlify.app

@prachi00 prachi00 changed the title #1326 tooltip in profile #1326 tooltip in profile nuxt Dec 10, 2021
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Duplicate Tabs in profile

@yangwao
Copy link
Member

yangwao commented Dec 10, 2021

yeah works for me original feature,

image

but behaves broken, might not be related to this commit, might be

image

@roiLeo
Copy link
Contributor

roiLeo commented Dec 15, 2021

Hey! @prachi00 It seems that we still have the duplicated tabs here

@prachi00
Copy link
Member Author

Hey! @prachi00 It seems that we still have the duplicated tabs here

@roiLeo where? I am unable to see it

@roiLeo
Copy link
Contributor

roiLeo commented Dec 15, 2021

Hey! @prachi00 It seems that we still have the duplicated tabs here

@roiLeo where? I am unable to see it

See preview:
https://deploy-preview-1484--koda-nuxt.netlify.app/rmrk/u/HCWd8fTKDejDe8nq2qJXzF3U9J3DZx3SQXUNmwLxC1sLrso
Something went wrong.

@prachi00
Copy link
Member Author

Hey! @prachi00 It seems that we still have the duplicated tabs here

@roiLeo where? I am unable to see it

See preview: https://deploy-preview-1484--koda-nuxt.netlify.app/rmrk/u/HCWd8fTKDejDe8nq2qJXzF3U9J3DZx3SQXUNmwLxC1sLrso Something went wrong.

Have fixed this

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one small change + indentation fix on <b-tabs>

@yangwao
Copy link
Member

yangwao commented Dec 16, 2021

@yangwao yangwao merged commit 479458b into kodadot:main-nuxt Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants