-
-
Notifications
You must be signed in to change notification settings - Fork 365
✨ GalleryItem description wrapper #1475
✨ GalleryItem description wrapper #1475
Conversation
|
✔️ Deploy Preview for koda-nuxt ready! 🔨 Explore the source changes: 215c8d9 🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61b328809d868200076fee6a 😎 Browse the preview: https://deploy-preview-1475--koda-nuxt.netlify.app |
|
✔️ Deploy Preview for koda-nuxt ready! 🔨 Explore the source changes: 1f3ca72 🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61b724dda8fce300072f5236 😎 Browse the preview: https://deploy-preview-1475--koda-nuxt.netlify.app |
vikiival
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cute!
Let it snow! ❄️
|
We discussed it with @yangwao and It would be better to move the And leave Collection item as it is |
With the previous wrapper? |
|
Overall I really welcome this approach,
yeah, point is that we want users at the collection to focus on the numbers, For gallery item, this would be a super value add as some collections have tons of un-interesting texts tbh! and I basically just eyeball piece and that's it. We can add it btw to vuex if people want it to be folded or unfolded |
vikiival
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Let it fly
|
How? |
? |


PR type
Before submitting Pull Request, please make sure:
Optional
What's new?
Screenshot
small description
large description