Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 10, 2021

PR type

  • Bugfix
  • Feature

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>

What's new?

Screenshot

small description

Screenshot 2021-12-10 at 11-06-34 nft-gallery-nuxt

large description

Screenshot 2021-12-10 at 11-07-06 nft-gallery-nuxt

@roiLeo roiLeo requested a review from vikiival December 10, 2021 10:15
@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 215c8d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61b328809d868200076fee6a

😎 Browse the preview: https://deploy-preview-1475--koda-nuxt.netlify.app

@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 1f3ca72

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61b724dda8fce300072f5236

😎 Browse the preview: https://deploy-preview-1475--koda-nuxt.netlify.app

@roiLeo roiLeo added enhancement New feature or request A-nuxt labels Dec 10, 2021
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute!

Let it snow! ❄️

@vikiival
Copy link
Member

vikiival commented Dec 10, 2021

We discussed it with @yangwao and It would be better to move the DescriptionWrapper into the GalleryItem.vue

And leave Collection item as it is

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 10, 2021

And leave Collection item as it is

With the previous wrapper?

@yangwao
Copy link
Member

yangwao commented Dec 10, 2021

Overall I really welcome this approach,
it makes our UI more polished and adult! 😄

And leave Collection item as it is

With the previous wrapper?

yeah, point is that we want users at the collection to focus on the numbers,
so if you can come up with some neat solutions which include this one and don't disturb audience, let's see.
If there is potential to replace the eye icon for down chevron, I'm up to it!

image

For gallery item, this would be a super value add as some collections have tons of un-interesting texts tbh! and I basically just eyeball piece and that's it. We can add it btw to vuex if people want it to be folded or unfolded

#1308 #1118 #1160

@roiLeo roiLeo marked this pull request as draft December 10, 2021 14:47
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 10, 2021

Screenshot 2021-12-10 at 16-06-14 nft-gallery-nuxt

@roiLeo roiLeo marked this pull request as ready for review December 10, 2021 15:09
@roiLeo roiLeo changed the title ✨ collection description wrapper ✨ GalleryItem description wrapper Dec 10, 2021
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Let it fly

@vikiival vikiival enabled auto-merge December 13, 2021 10:44
@vikiival vikiival merged commit 5a41c20 into kodadot:main-nuxt Dec 13, 2021
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 13, 2021

How?

@vikiival
Copy link
Member

vikiival commented Dec 13, 2021

How?

?

@roiLeo roiLeo deleted the feature/descriptionWrapper branch December 29, 2021 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-nuxt enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i cant select the text in collection description / or click on the link

3 participants