Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@kkukelka
Copy link
Member

@kkukelka kkukelka commented Dec 5, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

kodadot-pr-faq

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@netlify
Copy link

netlify bot commented Dec 5, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 7b02ae0

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61afb6209ba1aa0007fea550

😎 Browse the preview: https://deploy-preview-1399--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 6, 2021

@kkukelka can you merge recent main-nuxt as we've found out recent builds we're failing and now should be okayish!
So I can check on your contribution

@kkukelka
Copy link
Member Author

kkukelka commented Dec 6, 2021

@kkukelka can you merge recent main-nuxt as we've found out recent builds we're failing and now should be okayish! So I can check on your contribution

done 👍

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to have current nft minting fee in common file (@.common:data.KSM.fee) or something like that?

@yangwao
Copy link
Member

yangwao commented Dec 7, 2021

wouldn't it be better to have current nft minting fee in common file (@.common:data.KSM.fee) or something like that?

Oh, I've misread. That's great suggestion!

Yes, @kkukelka if you can add it to one place, so it's not copied over, that would be more than perfect and I can even close #1419

@kkukelka
Copy link
Member Author

kkukelka commented Dec 7, 2021

wouldn't it be better to have current nft minting fee in common file (@.common:data.KSM.fee) or something like that?

Oh, I've misread. That's great suggestion!

Yes, @kkukelka if you can add it to one place, so it's not copied over, that would be more than perfect and I can even close #1419

Sure thing!

@roiLeo roiLeo added the A-nuxt label Dec 7, 2021
@kkukelka kkukelka requested a review from roiLeo December 7, 2021 19:29
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@yangwao
Copy link
Member

yangwao commented Dec 8, 2021

@yangwao yangwao merged commit 798db3a into kodadot:main-nuxt Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand what are minting costs on KodaDot

3 participants