Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@jbienesdev
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at /transfer
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

Receiver with on-chain identity

image

Receiver without on-chain identity

image

@netlify
Copy link

netlify bot commented Dec 5, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 8e73505

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61adb02289e9dd000750f53a

😎 Browse the preview: https://deploy-preview-1396--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Dec 5, 2021

LGTM, yet I'm thinking about the state till resolving finishes.
To tell the user if it's fetching identity so can be sure there is no identity of the destination address.

Do you have an idea how to do that?

@jbienesdev
Copy link
Contributor Author

@yangwao we can add the infinity loader that we're using while it's still fetching the identity.

This is how it would look like with the loader (added a setTimeout for it to be noticeable)

Address with on-chain identity

screencast.2021-12-06.14-23-37.mp4

Address without on-chain identity

screencast.2021-12-06.14-24-22.mp4

Also, I added a new prop showOnchainIdentity so that other components that uses <Identity /> will not be affected. What do you think?

@yangwao
Copy link
Member

yangwao commented Dec 7, 2021

yeah works for me!

@yangwao
Copy link
Member

yangwao commented Dec 7, 2021

@jbienesdev I love emphasis on detial, here goes payout! https://kusama.subscan.io/extrinsic/0x08db70546ab386cbe844f4fbf98f979e219eae00765eb68a64300abb3db5f9bc

Let's chop on another issues

🌳🌳🌳 🪓 🪵

@yangwao yangwao merged commit 09aa34f into kodadot:main-nuxt Dec 7, 2021
@jbienesdev jbienesdev deleted the issue-1317 branch December 7, 2021 12:58
@jbienesdev
Copy link
Contributor Author

jbienesdev commented Dec 7, 2021

Received. Thanks! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show on-chain identity for destination address in transfer

2 participants