Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@jbienesdev
Copy link
Contributor

@jbienesdev jbienesdev commented Nov 23, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at /rmrk/mint and /rmrk/create
  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.
screencast.2021-11-24.00-20-53.mp4

There's an edge case on the carbonless NFT tooltip wherein we have a hyperlink inside but currently we aren't able to click it since the tooltip closes immediately when hovering away from the button. Another solution for this is to make the tooltip trigger on click instead of hover and tracking the active state of the tooltip. What are your thoughts?

@netlify
Copy link

netlify bot commented Nov 23, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 2110a66

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/619d1800888eb40007c97d8b

😎 Browse the preview: https://deploy-preview-1277--koda-nuxt.netlify.app

@vikiival
Copy link
Member

Hey,
Which branch did you used as a base?

@jbienesdev
Copy link
Contributor Author

Hi @vikiival I used main-nuxt as my base branch

@yangwao
Copy link
Member

yangwao commented Nov 30, 2021

Payout sent @jbienesdev https://kusama.subscan.io/extrinsic/10320344-4

let's pick another issues to work on!

@yangwao yangwao merged commit 2d516f0 into kodadot:main-nuxt Nov 30, 2021
@jbienesdev
Copy link
Contributor Author

Received! Sure will look for other issues to work on 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tooltip to explain switches at while minting for creators

3 participants