Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

🎩 new logo & favicon #1274

Merged
vikiival merged 19 commits into from
Dec 30, 2021
Merged

🎩 new logo & favicon #1274

vikiival merged 19 commits into from
Dec 30, 2021

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 23, 2021 •
edited
Loading

New branch, new me

PR type

  • Feature

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

What's new?

Screenshot v3

Screenshot 2021-11-24 at 09-43-17 KodaDot - Kusama NFT Market explorer

@netlify
Copy link

netlify bot commented Nov 23, 2021 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: bf25c18

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61cb8e6634857e00075f0fe2

😎 Browse the preview: https://deploy-preview-1274--koda-nuxt.netlify.app

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 23, 2021

KODADOT V3?

Capture d’écran 2021-11-23 à 4 39 23 PM

@vikiival
Copy link
Member

vikiival commented Nov 23, 2021

KODADOT V3?

Capture d’écran 2021-11-23 à 4 39 23 PM

❤️ ❤️ ❤️ ❤️
Yes please, but for navbar logo please use the small one (K.)
Moreover I would make the logo smaller

@yangwao
Copy link
Member

yangwao commented Nov 23, 2021

For navbar, I would use probably this first one as in that small you would not see the texture
Link for faster extraction from figma https://www.figma.com/file/XEiqGUitNgIFE0AIgA6XAx/KodaDot_Design-Kit?node-id=0%3A1
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 24, 2021 •
edited
Loading

For navbar, I would use probably this first one as in that small you would not see the texture

Screenshot 2021-11-24 at 09-22-27 KodaDot - Kusama NFT Market explorer

That was painful to export. SVG not working well.

  • Which one should I take for favicon?
  • Wich logo for images placeholder?
  • Should I change meta images too?

Test

Current

Frame 4

Current without sharp border

Frame 4(1)

@vikiival
Copy link
Member

vikiival commented Nov 25, 2021

You do not want a file with name assets/K..svg.
Actually do you use it somewhere?

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 26, 2021

You do not want a file with name assets/K..svg. Actually do you use it somewhere?

Nope, wanted to export logo as svg but didn't worked well, I'm removing it.
Will change logo name for sure.

@yangwao yangwao mentioned this pull request Nov 30, 2021
Closed
@roiLeo roiLeo added the A-nuxt label Dec 1, 2021
@yangwao
Copy link
Member

yangwao commented Dec 1, 2021

@roiLeo let's merge recent main-nuxt to update preview and push this forward

re this #1355 (comment)

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 1, 2021

@roiLeo let's merge recent main-nuxt to update preview and push this forward

re this #1355 (comment)

Updated!

Need feedback on this:

  • Which one should I take for favicon?
  • Wich logo for images placeholder?
  • Should I change meta images too with new one?

@roiLeo roiLeo marked this pull request as draft December 7, 2021 09:46
@yangwao yangwao mentioned this pull request Dec 15, 2021
Closed
@vikiival
Copy link
Member

vikiival commented Dec 24, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2021

Discovery Channel Gold GIF by Discovery

@vikiival vikiival mentioned this pull request Dec 24, 2021
Closed
11 tasks
@vikiival
Copy link
Member

vikiival commented Dec 24, 2021

Ready to merge? 👁️ 👅 👁️

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 24, 2021

@vikiival tested with larger logo, what do you think?
Screenshot 2021-12-24 at 09-41-34 nft-gallery-nuxt

Still go issue with exporing "K." logo to svg

@roiLeo roiLeo mentioned this pull request Dec 24, 2021
Closed
@roiLeo roiLeo marked this pull request as ready for review December 27, 2021 08:24
vikiival
vikiival reviewed Dec 27, 2021
View reviewed changes
vikiival
vikiival approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@vikiival
Copy link
Member

vikiival commented Dec 27, 2021

Screenshot 2021-12-27 at 09 39 53

Looks like the build fail

@roiLeo roiLeo marked this pull request as draft December 27, 2021 08:54
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 27, 2021

I wanted to delete unused component but founds out it's been used by statemine & westmint

@roiLeo roiLeo marked this pull request as ready for review December 27, 2021 08:56
@roiLeo roiLeo mentioned this pull request Dec 27, 2021
Closed
@vikiival vikiival merged commit ebbf75a into kodadot:main-nuxt Dec 30, 2021
@yangwao
Copy link
Member

yangwao commented Dec 30, 2021

wait I need to go through colors check, just replace logo not adjusting colors :D

@vikiival
Copy link
Member

vikiival commented Dec 30, 2021

/giphy will it blend

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2021

will it blend that smile GIF by Digg

@yangwao
Copy link
Member

yangwao commented Dec 30, 2021

Re colours continue here #1638

and pls use svg whenever we can

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vikiival vikiival vikiival approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-nuxt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update social media cards Add kodadot v3 logo Specialized Twitter Cards for each view

3 participants

@roiLeo @vikiival @yangwao