Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@dezine2dev
Copy link
Contributor

@dezine2dev dezine2dev commented Nov 22, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

What's new?

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot for others, is best to understand changes.

@github-actions
Copy link
Contributor

You're Pull Request scored a 0 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 50882dd

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/619ba274e713b500078ef6f7

😎 Browse the preview: https://deploy-preview-1255--koda-nuxt.netlify.app

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not seem correct (haven't tried)

:items="collections"
type="collectionDetail"
link="rmrk/collection"
link="rmrk/collections"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u sure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This is my next plan to take a look.
This is actually not just a problem with this collection.
I see that we need to improve LinkResolver and its usage in nuxt project.

@yangwao
Copy link
Member

yangwao commented Nov 23, 2021

if that fix some routes, but it's not complete fix @dezine2dev

@yangwao yangwao merged commit 38ec998 into main-nuxt Nov 23, 2021
@yangwao yangwao deleted the issue-1251 branch January 13, 2022 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing routes to Nuxt

4 participants