Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 15, 2021

Thank you for your contribution to the KodaDot NFT gallery.

👇 Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested PR on mobile and everything works
  • I found edge cases

What's new?

@yangwao
Copy link
Member

yangwao commented Nov 15, 2021

Is it possible to challenge this bug? :D
tl;dr;
image

Screen.Recording.2021-11-15.at.10.20.05.mov

@yangwao
Copy link
Member

yangwao commented Nov 15, 2021

Double layout! :D
image

@roiLeo roiLeo marked this pull request as draft November 15, 2021 10:14
@roiLeo roiLeo marked this pull request as ready for review November 15, 2021 10:35
@yangwao
Copy link
Member

yangwao commented Nov 15, 2021

I'm looking at on the right PR deployment? https://deploy-preview-1147--nftkodadot.netlify.app/rmrk/collection/242c96bed4f3602b04-4ZLBF

if so, 1147 still has this double layout

image

@yangwao
Copy link
Member

yangwao commented Nov 15, 2021

I should not be testing code, I break stuff 😄

https://deploy-preview-1147--nftkodadot.netlify.app/rmrk/collection/1eded96180db41f86e-KUTE

image

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 15, 2021

I should not be testing code, I break stuff 😄

https://deploy-preview-1147--nftkodadot.netlify.app/rmrk/collection/1eded96180db41f86e-KUTE

image

Weird, I can't reproduce it. Maybe try to clear your browser cache.

@yangwao
Copy link
Member

yangwao commented Nov 15, 2021

oh yeah, I'm always special.
Seems service worker doesn't update well everytime, it's not first time what I've encountered 👀

@yangwao yangwao merged commit 1648eba into kodadot:main Nov 15, 2021
@roiLeo roiLeo deleted the feature/collection/skelton branch November 15, 2021 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants