Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@vikiival
Copy link
Member

@vikiival vikiival commented Nov 10, 2021

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!

Fix #1077

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile
  • Are there any edge cases? Name if any

Screenshot 2021-11-10 at 16 07 58

@netlify
Copy link

netlify bot commented Nov 10, 2021

❌ Deploy Preview for koda-nuxt failed.

🔨 Explore the source changes: c7abfa8

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/618bf94536d22800089e2be8

@github-actions
Copy link
Contributor

You're Pull Request scored a 0.029411764705882353 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@vikiival vikiival marked this pull request as draft November 10, 2021 14:06
@vikiival vikiival marked this pull request as ready for review November 10, 2021 15:07
@vikiival vikiival requested a review from dezine2dev November 10, 2021 15:08
Copy link
Contributor

@dezine2dev dezine2dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
One quick questions - I see some images are moved from public/ to static/. Is there any reason for this?

@yangwao
Copy link
Member

yangwao commented Nov 10, 2021

Those which are in public should stay there as might be linked outside of our app tho.

@yangwao yangwao merged commit 6599e11 into main-nuxt Nov 10, 2021
@yangwao yangwao deleted the 1077-swap branch November 10, 2021 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync main branch into main-nuxt

4 participants