Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 5, 2021

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it on mobile and everything works
  • I found edge cases

What's new? (may be part of changelog)

If issue had bounty label ($,$$,$$$)

Community participation

Screenshot

  • Whenever my fix has changed something on UI, a screenshot for others, is more than welcome

Screenshot 2021-11-05 at 6 50 18 PM

@yangwao yangwao requested review from roiLeo and vikiival and removed request for vikiival November 5, 2021 14:45
@yangwao
Copy link
Member

yangwao commented Nov 5, 2021

Hey, why pagination component has changed position?
Please keep it at original place and keep same border as < and >
image

@prachi00
Copy link
Member Author

prachi00 commented Nov 5, 2021

Hey, why pagination component has changed position? Please keep it at original place and keep same border as < and > image
Fixed:

Screenshot 2021-11-05 at 11 17 12 PM

@yangwao
Copy link
Member

yangwao commented Nov 8, 2021

LGTM

@yangwao yangwao merged commit f53c8bb into kodadot:main Nov 8, 2021
@yangwao
Copy link
Member

yangwao commented Nov 8, 2021

Payout sent @prachi00 ! https://kusama.subscan.io/extrinsic/0xc3197321e54f07b4c30f676853ed8954e088b58e50743f6f289105c716139cbc

Let's check #1058

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take me to random page at pagination component

3 participants