feat: added support for clickhouse#48
Merged
kndndrj merged 1 commit intokndndrj:masterfrom Jan 6, 2024
Merged
Conversation
stephenafamo
force-pushed
the
clickhouse
branch
from
34cb96e to
b129933
Compare
Owner
|
@stephenafamo I see that you updated for refactor. Thanks a lot! I'll go over the code and point out (or fix) if I fknd anything obvious. Other than that I trust that you tested it yourself and it is working. |
Contributor
Author
|
Yes, I've tested locally and it works. However, I do get an error while trying to open some Postgres connections of the form. Interestingly, this does not happen for all connections 
|
Owner
|
hmm, at a glance it looks like an issue with either pq or local file system permissions. If you want you can try to recreate the issue with minimal go program :). Otherwise if the issue persists, you can create an issue here on github. |
kndndrj
approved these changes
Jan 6, 2024
Owner
kndndrj
left a comment
kndndrj
left a comment
There was a problem hiding this comment.
looks good - don't know the details of clickhouse, so I leave that to trust :D
kndndrj
added a commit
that referenced
this pull request
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.