Allow reconstructSome to reconstruct parity shards #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
Jan 5, 2024
rootulp
reviewed
Jan 5, 2024
| t.Fatal("ReconstructSome did not reconstruct required shards correctly") | ||
| } | ||
|
|
||
| // Reconstruct 3 shards with 3 data and 5 parity shards |
Contributor
There was a problem hiding this comment.
[question] not directly related to this PR but why does this claim to reconstruct 3 shards when below only two shares are requested for reconstruction:
shardsRequired = make([]bool, 8)
shardsRequired[3] = true
shardsRequired[4] = trueshould it instead state:
// Reconstruct 2 shards...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation idea for: #266