update exports in main.ts to avoid exporting internal utilities/types#741
Merged
stackoverfloweth merged 1 commit intomainfrom Mar 19, 2026
Merged
update exports in main.ts to avoid exporting internal utilities/types#741stackoverfloweth merged 1 commit intomainfrom
stackoverfloweth merged 1 commit intomainfrom
Conversation
…tended to be public
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pleek91
approved these changes
Mar 19, 2026
| // Types | ||
| export * from './types/createRouteOptions' | ||
| export * from './types/hooks' | ||
| export type { |
Contributor
There was a problem hiding this comment.
This makes sense. But I also wonder if we should just add a linting rule about nothing but types in the types folder. Then export everything. Then we can export specific actual code from other directories. Maybe something for future us.
Contributor
Author
There was a problem hiding this comment.
yeah, I like that for future us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update exports to avoid API docs generation for things that aren't intended to be public
this issue was flagged in this auto-generated docs PR