Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

httpbin covert to helm chart#965

Merged
knrt10 merged 2 commits intomasterfrom
knrt10/httpbin-covert-to-helm
Sep 15, 2020
Merged

httpbin covert to helm chart#965
knrt10 merged 2 commits intomasterfrom
knrt10/httpbin-covert-to-helm

Conversation

@knrt10
Copy link
Contributor

@knrt10 knrt10 commented Sep 15, 2020

closes: #957

Signed-off-by: knrt10 kautilya@kinvolk.io

@knrt10 knrt10 requested review from invidian and surajssd September 15, 2020 06:06
@knrt10 knrt10 changed the title httpbin covert to helm httpbin covert to helm chart Sep 15, 2020
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the CI failing.

@knrt10 knrt10 force-pushed the knrt10/httpbin-covert-to-helm branch from eeb2f56 to 1422745 Compare September 15, 2020 06:14
@knrt10
Copy link
Contributor Author

knrt10 commented Sep 15, 2020

I don't know why it's failing, I ran make update-assets. still it fails

@invidian
Copy link
Member

I don't know why it's failing, I ran make update-assets. still it fails

you need to remove empty directory from assets, as update-assets includes it locally, but when you take your branch and do a fresh clone, git won't include empty directories.

knrt10 added 2 commits September 15, 2020 11:53
closes: #957

Signed-off-by: knrt10 <kautilya@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/httpbin-covert-to-helm branch from 1422745 to dacd9cc Compare September 15, 2020 06:23
@knrt10
Copy link
Contributor Author

knrt10 commented Sep 15, 2020

Thanks, didn't knew about this

@knrt10 knrt10 requested a review from invidian September 15, 2020 06:24
@invidian
Copy link
Member

Thanks, didn't knew about this

Hmm, I guess we could run find assets/ -type d -empty | wc -l or something as part of the update-assets and fail if there are empty directories laying around there.

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@knrt10 knrt10 merged commit b3583fc into master Sep 15, 2020
@knrt10 knrt10 deleted the knrt10/httpbin-covert-to-helm branch September 15, 2020 07:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httpbin: convert to helm chart

3 participants