Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Add document for admission webhook#943

Merged
knrt10 merged 1 commit intomasterfrom
knrt10/document-webhook-controller
Sep 22, 2020
Merged

Add document for admission webhook#943
knrt10 merged 1 commit intomasterfrom
knrt10/document-webhook-controller

Conversation

@knrt10
Copy link
Contributor

@knrt10 knrt10 commented Sep 10, 2020

Closes: #913

Signed-off-by: knrt10 kautilya@kinvolk.io

@knrt10 knrt10 requested review from invidian and johananl September 10, 2020 14:15
invidian
invidian suggested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts.

@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from a79b506 to 614d779 Compare September 11, 2020 11:43
@knrt10 knrt10 requested a review from invidian September 11, 2020 11:43
@knrt10
Copy link
Contributor Author

knrt10 commented Sep 11, 2020

@invidian does this look ok?

invidian
invidian suggested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knrt10 I think we still need to iterate a bit over this document to make the content more concise and specific. Please see my comments.

@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from 614d779 to 0178731 Compare September 16, 2020 10:32
@knrt10 knrt10 requested a review from invidian September 16, 2020 10:33
invidian
invidian previously requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. In general it looks better now, but I think still @iaguis or @johananl should have a look at it.

@invidian invidian requested a review from iaguis September 16, 2020 11:13
@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from 0178731 to bd9bbe0 Compare September 16, 2020 11:27
invidian
invidian reviewed Sep 16, 2020
View reviewed changes
@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from bd9bbe0 to 9a763fc Compare September 16, 2020 11:33
@knrt10 knrt10 requested a review from invidian September 16, 2020 11:33
johananl
johananl previously requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knrt10. The info looks good to me, however there are multiple language problems which I think should be fixed. I'll do my best to add a proper docs style guide to the repo soon so that things will seem less "arbitrary".

@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from 9a763fc to 5c7fa58 Compare September 21, 2020 10:50
@knrt10 knrt10 requested a review from johananl September 21, 2020 10:50
@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from 5c7fa58 to b6e612a Compare September 21, 2020 10:52
@knrt10 knrt10 dismissed stale reviews from invidian and johananl September 21, 2020 11:39

re requesting review

invidian
invidian previously approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

johananl
johananl reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better to me @knrt10.

I still have a few more nitpicks though :-)

@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from b6e612a to 11e7541 Compare September 22, 2020 06:41
@knrt10 knrt10 requested review from invidian and johananl September 22, 2020 06:41
invidian
invidian previously approved these changes Sep 22, 2020
View reviewed changes
johananl
johananl reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Looks better.

I've left some comments.

@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from 11e7541 to d843603 Compare September 22, 2020 11:25
@knrt10
Copy link
Contributor Author

knrt10 commented Sep 22, 2020

@johananl updated

@knrt10 knrt10 requested review from invidian and johananl September 22, 2020 11:25
Add document for admission webhook
621711b 
Closes: #913

Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/document-webhook-controller branch from d843603 to 621711b Compare September 22, 2020 11:26
johananl
johananl approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knrt10
Copy link
Contributor Author

knrt10 commented Sep 22, 2020

Thanks @johananl @invidian for through review

@knrt10 knrt10 merged commit 8093a06 into master Sep 22, 2020
@knrt10 knrt10 deleted the knrt10/document-webhook-controller branch September 22, 2020 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iaguis iaguis Awaiting requested review from iaguis

2 more reviewers

@johananl johananl johananl approved these changes

@invidian invidian invidian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the behaviour of webhook controller

3 participants

@knrt10 @johananl @invidian