Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

docs: fix etcd version upgrade sed expression#921

Merged
surajssd merged 1 commit intokinvolk:masterfrom
niels-s:fix_etcd_upgrade_docs
Sep 9, 2020
Merged

docs: fix etcd version upgrade sed expression#921
surajssd merged 1 commit intokinvolk:masterfrom
niels-s:fix_etcd_upgrade_docs

Conversation

@niels-s
Copy link
Contributor

@niels-s niels-s commented Sep 8, 2020

When upgrading the etcd version of a node, you need to update the local
etcd cluster configuration. The previous sed expression missed appending
an ending double quote to the ETCD_IMAGE_TAG environment variable.
This prevented the correct version from being installed, hence not
updating at all.

Closes #920

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @niels-s! Can you please add Closes #920 into the commit message and PR description? Otherwise LGTM.

When upgrading the etcd version of a node, you need to update the local
etcd cluster configuration. The previous sed expression missed appending
an ending double quote to the `ETCD_IMAGE_TAG` environment variable.
This prevented the correct version from being installed, hence not
updating at all.

Closes kinvolk#920
@niels-s niels-s force-pushed the fix_etcd_upgrade_docs branch from b0091b9 to 09f9429 Compare September 8, 2020 17:03
@niels-s niels-s requested a review from invidian September 8, 2020 17:03
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invidian invidian removed the request for review from johananl September 8, 2020 17:52
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @niels-s 🎉

@surajssd surajssd merged commit fb044ce into kinvolk:master Sep 9, 2020
@niels-s niels-s deleted the fix_etcd_upgrade_docs branch September 9, 2020 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

etcd upgrade docs: Fix the sed command

3 participants