Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Add cluster-autoscaler update check#862

Merged
knrt10 merged 1 commit intomasterfrom
knrt10/add-cluster-autoscaler-update-check
Aug 27, 2020
Merged

Add cluster-autoscaler update check#862
knrt10 merged 1 commit intomasterfrom
knrt10/add-cluster-autoscaler-update-check

Conversation

@knrt10
Copy link
Contributor

@knrt10 knrt10 commented Aug 26, 2020

To be merged after #859

Closes #809

Signed-off-by: knrt10 kautilya@kinvolk.io

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should close #809

@knrt10 knrt10 requested review from invidian, ipochi and surajssd August 27, 2020 09:39
@invidian
Copy link
Member

This should close #809

@knrt10 mind adding Closes #809 to commit message and PR description?

@knrt10 knrt10 force-pushed the knrt10/add-cluster-autoscaler-update-check branch from 8fca5d6 to e566d6f Compare August 27, 2020 09:43
@knrt10
Copy link
Contributor Author

knrt10 commented Aug 27, 2020

Updated

@knrt10 knrt10 linked an issue Aug 27, 2020 that may be closed by this pull request
@knrt10 knrt10 force-pushed the knrt10/add-cluster-autoscaler-update-check branch from e566d6f to 46baade Compare August 27, 2020 10:55
Closes #809

Signed-off-by: knrt10 <kautilya@kinvolk.io>
@knrt10 knrt10 force-pushed the knrt10/add-cluster-autoscaler-update-check branch from 46baade to b030a1f Compare August 27, 2020 10:55
@knrt10 knrt10 requested a review from invidian August 27, 2020 10:55
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knrt10
Copy link
Contributor Author

knrt10 commented Aug 27, 2020

Merging it, as this is small change and won't affect lokomotive

@knrt10 knrt10 merged commit 2d8994e into master Aug 27, 2020
@knrt10 knrt10 deleted the knrt10/add-cluster-autoscaler-update-check branch August 27, 2020 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a check for cluster autoscaler in find-updates

2 participants