This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Merged
Conversation
693c2d8 to
78db3bb
Compare
Member
Author
|
From testing on Packet, it seems following string must be added to the Terraform code to get things working: $ git diff
diff --git a/pkg/platform/packet/template.go b/pkg/platform/packet/template.go
index 6c7ea543..b449f8dd 100644
--- a/pkg/platform/packet/template.go
+++ b/pkg/platform/packet/template.go
@@ -287,4 +287,15 @@ output "lokomotive_values" {
value = module.packet-{{.Config.ClusterName}}.lokomotive_values
sensitive = true
}
+
+terraform {
+ required_version = ">= 0.13.0"
+
+ required_providers {
+ packet = {
+ source = "terraform-providers/packet"
+ version = "~> 2.7.3"
+ }
+ }
+}
`Note, that we render the |
ef58fd3 to
cf98394
Compare
5222ea2 to
7100402
Compare
67c66b9 to
84391ac
Compare
84391ac to
67fdddc
Compare
Member
Author
|
Rebased to include #1021, so CI can pass. |
knrt10
reviewed
Oct 5, 2020
Member
Author
67fdddc to
935b0b8
Compare
935b0b8 to
491affc
Compare
491affc to
84549f5
Compare
Member
|
The code looks ok to me, @invidian could you rebase and trigger the CI once more? |
Member
Author
|
@surajssd this is already based on latest master. I try to restart AKS job now.. |
84549f5 to
8946a7c
Compare
Member
Author
|
Well, re-pushed anyway, as CI seems to got stuck somehow |
8946a7c to
0672a10
Compare
Contributor
|
Restarted failed aks and packetARM pipelines |
knrt10
previously approved these changes
Oct 13, 2020
This module does not use this provider, so it shouldn't decide on provider version to use. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Closes #1022 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Closes #788 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
As it is more idiomatic than using Sscanf. '-json' parameter is a new option added in Terraform 0.13. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
0672a10 to
66274b4
Compare
knrt10
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Includes commits from #860.NOTE: Includes changes from #1027Closes #788
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io