This repository was archived by the owner on Jun 29, 2022. It is now read-only.
cli/cmd: improve --kubeconfig-file flag help message formatting#818
Merged
cli/cmd: improve --kubeconfig-file flag help message formatting#818
Conversation
Member
Author
|
BTW, I'm open for suggestions for different formatting. |
johananl
previously approved these changes
Aug 21, 2020
Member
johananl
left a comment
johananl
left a comment
There was a problem hiding this comment.
LGTM. Looks better than the current state.
I think you forgot to replace one of the backticks occurrences (see inline comment).
As for the formatting itself, visually it looks fine to me but I'm not sure sure we need to even include the info regarding order of precedence in the CLI help. IMO this sort of detailed info should live in the docs.
As currently, it produces line with 200+ characters, which just looks bad. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/kubeconfig-file-flag-formatting
branch
from
96a1eb4 to
6dacf93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As currently, it produces line with 200+ characters, which just looks
bad.
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io