This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Merged
Conversation
Merged
invidian
suggested changes
Aug 14, 2020
rata
reviewed
Aug 14, 2020
rata
reviewed
Aug 14, 2020
rata
reviewed
Aug 14, 2020
rata
reviewed
Aug 14, 2020
rata
reviewed
Aug 14, 2020
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
18f16d9 to
f5d24e0
Compare
rata
reviewed
Aug 14, 2020
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
2 times, most recently
from
48b034e to
7b2f3be
Compare
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
7b2f3be to
fbb60db
Compare
Member
Author
|
@rata done :-) Added the note on step 2 that it is needed only for deployments done using 0.4.0. |
invidian
previously approved these changes
Aug 18, 2020
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
fbb60db to
7c0e233
Compare
invidian
previously approved these changes
Aug 19, 2020
rata
previously approved these changes
Aug 19, 2020
Contributor
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, just one comment about when it is safe or not to continue (maybe being extra paranoid or cases that can't really happen :)).
Marking as approve as it might be a no-op and just answer my question without changes :)
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
7c0e233 to
fd056ae
Compare
invidian
reviewed
Aug 19, 2020
rata
reviewed
Aug 19, 2020
rata
reviewed
Aug 19, 2020
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
fd056ae to
2cae55e
Compare
invidian
previously approved these changes
Aug 19, 2020
rata
reviewed
Aug 19, 2020
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
2cae55e to
f16946a
Compare
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-etcd-upgrade-doc
branch
from
f16946a to
2b12057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.