Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

docs: Add CLC Snippet documentation for AWS and Packet#657

Merged
iaguis merged 1 commit intomasterfrom
cdavis/clc-snippets-documentation
Jun 30, 2020
Merged

docs: Add CLC Snippet documentation for AWS and Packet#657
iaguis merged 1 commit intomasterfrom
cdavis/clc-snippets-documentation

Conversation

@BrainBlasted
Copy link
Contributor

Related to #590

Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

@BrainBlasted BrainBlasted force-pushed the cdavis/clc-snippets-documentation branch from 5e756d9 to bdf1ae9 Compare June 23, 2020 17:30
@BrainBlasted BrainBlasted requested a review from iaguis June 23, 2020 18:02
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, lgtm after that

Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM minus my comments.

@iaguis
Copy link
Contributor

iaguis commented Jun 26, 2020

I think we're good to merge after fixing the last review comments :)

@BrainBlasted BrainBlasted force-pushed the cdavis/clc-snippets-documentation branch from bdf1ae9 to b0a20f2 Compare June 29, 2020 16:54
@BrainBlasted
Copy link
Contributor Author

Cleaned those up :)

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iaguis iaguis merged commit c892008 into master Jun 30, 2020
@iaguis iaguis deleted the cdavis/clc-snippets-documentation branch June 30, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants