This repository was archived by the owner on Jun 29, 2022. It is now read-only.
packet/nodes: switch back to baremetal_0 as default node type#642
Merged
packet/nodes: switch back to baremetal_0 as default node type#642
Conversation
Otherwise upgrading from v0.1.0 will cause all nodes to be recreated.
iaguis
force-pushed
the
iaguis/revert-packet-type
branch
from
aa856d7 to
9b6a966
Compare
Member
|
I think this PR was not necessary. Instead, users wishing to not migrate their worker pools to new type should define the value explicitly and we should recommend users to re-create the pools. |
Contributor
Author
That's a fair point. We could update this and mention in the release notes the change and recommend to define explicitly the instance type if using the default one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise upgrading from v0.1.0 will cause all nodes to be recreated.