Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

bootkube: use host's /etc/hosts entries #409

Merged
invidian merged 1 commit into from
Aug 18, 2020
Merged

bootkube: use host's /etc/hosts entries #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/aws/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
Copy link
Member

@johananl johananl May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we verified this doesn't have side effects? Also, I believe you're proposing to add this flag to all platforms for the sake of uniformity, however does it make sense to do that on platforms which don't need this functionality? I think it might be better to only add the flag where it's needed, to minimize potential "surprises" in the future.

Copy link
Member Author

@invidian invidian May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we verified this doesn't have side effects?

I cannot come up with any possible side effects of that beside benefits. This potentially allows to also use CLC snippets for /etc/hosts for names resolving for other platforms too (if using only Terraform code, which I know we don't support).

--exec=/bootkube -- start --asset-dir=/assets "$@"
- path: /etc/tmpfiles.d/etcd-wrapper.conf
filesystem: root
Expand Down
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/azure/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
--exec=/bootkube -- start --asset-dir=/assets "$@"
passwd:
users:
Expand Down
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/bare-metal/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
--exec=/bootkube -- start --asset-dir=/assets "$@"
- path: /etc/kubernetes/configure-kubelet-cgroup-driver
filesystem: root
Expand Down
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/google-cloud/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
--exec=/bootkube -- start --asset-dir=/assets "$@"
passwd:
users:
Expand Down
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/kvm-libvirt/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
--exec=/bootkube -- start --asset-dir=/assets "$@"
- path: /etc/kubernetes/configure-kubelet-cgroup-driver
filesystem: root
Expand Down
1 change: 1 addition & 0 deletions assets/lokomotive-kubernetes/packet/flatcar-linux/kubernetes/cl/controller.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ storage:
--insecure-options=image \
--net=host \
--dns=host \
--hosts-entry=host \
--exec=/bootkube -- start --asset-dir=/assets "$@"
- path: /etc/tmpfiles.d/etcd-wrapper.conf
filesystem: root
Expand Down
24 changes: 12 additions & 12 deletions pkg/assets/generated_assets.go
View file
Open in desktop

Large diffs are not rendered by default.