This repository was archived by the owner on Jun 29, 2022. It is now read-only.
baremetal: fix terraform non-parallel execution#1478
Merged
Conversation
In order to limit the number of cnocurrent operations as Terraform walks
the graph, `-parallelism=n` is used, with a default value of 10.
When rotating certificates, it is desirable to limit parallelism to `1`,
so that certificates are rotated one by one and we still have quorum.
In baremtal platform, there is a case of missing hiphen before
`parallelism`:
```
current - return ex.Apply([]string{"parallelism=1"})
correct - return ex.Apply([]string{"-parallelism=1"})
```
Hence the following error:
```
stat parallelism=1: no such file or directory
```
This commit provides the fix by correcting the code in question.
Signed-off-by: Imran Pochi <imran@kinvolk.io>
invidian
approved these changes
Jun 2, 2021
Member
|
I don't think there are 3 reviewers required for such trivial fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to limit the number of cnocurrent operations as Terraform walks
the graph,
-parallelism=nis used, with a default value of 10.When rotating certificates, it is desirable to limit parallelism to
1,so that certificates are rotated one by one and we still have quorum.
In baremtal platform, there is a case of missing hiphen before
parallelism:Hence the following error:
This commit provides the fix by correcting the code in question.
Signed-off-by: Imran Pochi imran@kinvolk.io