Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Include a "v" in version strings when releasing#1417

Merged
johananl merged 2 commits intomasterfrom
johananl/v-in-version-strings
Mar 5, 2021
Merged

Include a "v" in version strings when releasing#1417
johananl merged 2 commits intomasterfrom
johananl/v-in-version-strings

Conversation

@johananl
Copy link
Member

@johananl johananl commented Mar 5, 2021 •
edited
Loading

This PR ensures the version string printed by lokoctl version is consistent for binaries created using make and binaries created as part of the release process.

The GitHub URIs for released binaries are updated accordingly as well.

Fixes #1150.

To test the PR, create a fake Git tag, create a release without publishing it and ensure the printed version string has a "v":

git tag v0.7.0-test
goreleaser release --skip-publish --skip-sign
./dist/lokoctl_linux_amd64/lokoctl version

johananl added 2 commits March 4, 2021 15:00
@johananl
Include a "v" in goreleaser version strings
1baec2a 
For consistency with the Git tag, we should always prepend a "v" in
front of the Lokomotive version.
@johananl
Update URIs in quickstart guides
33ee135 
We've added a "v" in front of the Lokomotive version, which affects
GitHub URIs.
@johananl johananl requested review from iaguis, invidian and meyskens March 5, 2021 10:18
@iaguis iaguis mentioned this pull request Mar 5, 2021
Closed
invidian
invidian approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

iaguis
iaguis approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johananl johananl merged commit dc7324e into master Mar 5, 2021
@johananl johananl deleted the johananl/v-in-version-strings branch March 5, 2021 15:32
@johananl johananl mentioned this pull request Mar 17, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meyskens meyskens Awaiting requested review from meyskens

2 more reviewers

@iaguis iaguis iaguis approved these changes

@invidian invidian invidian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version string in released binaries is missing the "v"

3 participants

@johananl @iaguis @invidian