This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Merged
Conversation
pothos
reviewed
Jan 14, 2021
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/cl/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
pothos
reviewed
Jan 14, 2021
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
20ce593 to
5de830b
Compare
invidian
suggested changes
Jan 14, 2021
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/profiles.tf
Show resolved
Hide resolved
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/profiles.tf
Show resolved
Hide resolved
knrt10
suggested changes
Jan 16, 2021
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/variables.tf
Outdated
Show resolved
Hide resolved
pothos
reviewed
Jan 19, 2021
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
5de830b to
6a9e638
Compare
pothos
added a commit
to kinvolk/racker
that referenced
this pull request
Jan 19, 2021
In the final setup we can use an internal L2 network and don't need to rely on ipvlan. This makes the QEMU setup resemble the final setup but still keeps the PXE/DHCP server on the host system, not in a VM. The required lokoctl binary comes from kinvolk/lokomotive#1317
pothos
added a commit
to kinvolk/racker
that referenced
this pull request
Jan 19, 2021
In the final setup we can use an internal L2 network and don't need to rely on ipvlan. This makes the QEMU setup resemble the final setup but still keeps the PXE/DHCP server on the host system, not in a VM. The required lokoctl binary comes from kinvolk/lokomotive#1317
pothos
reviewed
Jan 19, 2021
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
6a9e638 to
a025a47
Compare
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
a025a47 to
c764787
Compare
invidian
previously approved these changes
Jan 20, 2021
knrt10
suggested changes
Jan 20, 2021
Contributor
knrt10
left a comment
knrt10
left a comment
There was a problem hiding this comment.
I think baremetal: enhance clc_snippets type and baremetal: remove locals clc_map should be committed together as they are interdependent. What do you think?
Member
Author
|
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
c764787 to
4ca496b
Compare
pothos
reviewed
Jan 20, 2021
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/cl/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
added 4 commits
January 20, 2021 20:22
This commit adds two configuration options: `install_disk` and `install_to_smallest_disk`. `install_disk` provides the disk path to install Flatcar Container Linux. This configuration optionw as present on the terraform side but not exposed on the Lokomotive side. `install_to_smallest_disk`: whether to install Flatcar Container Linux on the smallest disk partition or use the value provided in `install_disk`. This is a new configuration option for Lokomotive. Also add unit tests and updates the configuration reference documentation. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit adds a configuration option for Lokomotive: `kernel_args`. This configuration knob is already exposed on the Terraform side of the Lokomotive code but not exposed to the user via configuration. Also updates the configuration reference documentation. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit adds `download_protocol` as a Lokomotive configuration exposed to the user. This configuration knob was already present on the Lokomotive terraform code. This commit also adds unit tests and updates the configuration reference documentation. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commits add the configuration option for Lokomotive, which was already available on the Terraform side. This commit also updates the documentation. Signed-off-by: Imran Pochi <imran@kinvolk.io>
added 4 commits
January 20, 2021 20:22
This commit updates the type of `clc_snippets` from `map(string)` to `map(list(string))`. This is done so that multiple clc snippets can be passed instead of just one. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit updates the code which was present due to limitations in Terraform <= 0.12, Since Lokomotive now supports 0.13 version and the type of `clc_snippets` is updated from map(string) to map(list(string)), the code is no longer required. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit adds functionality to add CLC snippets to the Baremetal Lokomotive configuration. Updates the existing CLC snippet test to also cover baremetal platform. Updates the Baremetal configuration reference documentation to include the new variable `clc_snippets`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/baremetal-feature-parity
branch
from
4ca496b to
c8b7a39
Compare
invidian
approved these changes
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configuration knobs to Lokomotive which are present on the Terraform side such as:
install_disknetwork_ip_autodetectionkernel_argsdownload_protocolAlso adds a new configuration option:
install_to_smallest_partitionwhich installs Flatcar Container Linux on the smallest disk partition.