Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

docs: Rename upgrade docs to update docs#1294

Merged
surajssd merged 1 commit intomasterfrom
surajssd/update-not-upgrade
Jan 4, 2021
Merged

docs: Rename upgrade docs to update docs#1294
surajssd merged 1 commit intomasterfrom
surajssd/update-not-upgrade

Conversation

@surajssd
Copy link
Member

No description provided.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Please add some explanation to commit message why we should prefer update over upgrade, as it is not obvious (to me at least).

@surajssd
Copy link
Member Author

surajssd commented Jan 4, 2021

@invidian the only context I have is #1292 (review), but @knrt10 can add more I think. So I was trying to make the change homogenous.

@knrt10
Copy link
Contributor

knrt10 commented Jan 4, 2021

More context #1118 (comment)

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not entirely sure this is what @johananl had in mind. I mean, if it should apply to all use of "upgrade" word.

However, after looking at https://www.quora.com/What-is-the-difference-between-upgrade-and-update for example, it seems to me that indeed use of word update is more accurate than upgrade in most cases, as I cannot find a good example of "grades" in our case. I suppose one could upgrade from Flatcar to Flatcar LTS, as it is a different grade of a product, but for Lokomotive, there is no equivalent. It's the same for mentioned Terraform.

Perhaps we could include that in our style guide to avoid further confusion.

@surajssd surajssd merged commit 2d89e53 into master Jan 4, 2021
@surajssd surajssd deleted the surajssd/update-not-upgrade branch January 4, 2021 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants