This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Merged
Conversation
Member
|
I probably won't have time to review it for now. |
surajssd
suggested changes
Jan 19, 2021
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
aee8f1e to
8c33ee2
Compare
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
8c33ee2 to
878be81
Compare
surajssd
reviewed
Feb 10, 2021
Member
surajssd
left a comment
surajssd
left a comment
There was a problem hiding this comment.
A small nit, otherwise rest LGTM.
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
878be81 to
69b2943
Compare
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
3 times, most recently
from
806285c to
89723f9
Compare
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
89723f9 to
a715264
Compare
iaguis
suggested changes
Mar 2, 2021
Contributor
iaguis
left a comment
iaguis
left a comment
There was a problem hiding this comment.
Some comments. Tested it and functionality-wise looks good.
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
a715264 to
a047107
Compare
closes: #613 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/refactor-aws-quickstart
branch
from
a047107 to
0702c8b
Compare
surajssd
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #613
Signed-off-by: knrt10 kautilya@kinvolk.io