This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Remove Deprecated CoreOS from AWS terraform#1245
Merged
invidian merged 5 commits intokinvolk:masterfrom Dec 9, 2020
karlskewes:1202-tf-lint
Merged
Remove Deprecated CoreOS from AWS terraform#1245invidian merged 5 commits intokinvolk:masterfrom karlskewes:1202-tf-lint
invidian merged 5 commits intokinvolk:masterfrom
karlskewes:1202-tf-lint
Conversation
Contributor
|
@kskewes thanks for the PR, would you mind rebasing the PR from the master, that might fix the CI test which was fixed by #1242 |
karlskewes
changed the title
Member
|
@kskewes please run |
invidian
suggested changes
Dec 8, 2020
Member
invidian
left a comment
invidian
left a comment
There was a problem hiding this comment.
I tested it manually, as we currently don't have a CI process for outside contributions (#1247) and I got the following errors:
module.aws-l8e-mat.data.aws_ami.flatcar: Refreshing state...
Error: Incorrect attribute value type
on ../terraform-modules/aws/flatcar-linux/kubernetes/controllers.tf line 88, in resource "aws_instance" "controllers":
88: ami = local.ami_id
|----------------
| local.ami_id is tuple with 1 element
Inappropriate value for attribute "ami": string required.
Error: Incorrect attribute value type
on ../terraform-modules/aws/flatcar-linux/kubernetes/workers/workers.tf line 58, in resource "aws_launch_configuration" "worker":
58: image_id = local.ami_id
|----------------
| local.ami_id is tuple with 1 element
Inappropriate value for attribute "image_id": string required.
FATA[0010] Applying cluster failed: applying platform: failed checking execution status: exit status 1 args="[]" command="lokoctl cluster apply"
Member
|
Thanks @kskewes. I'll test this tomorrow. |
knrt10
approved these changes
Dec 9, 2020
Contributor
knrt10
left a comment
knrt10
left a comment
There was a problem hiding this comment.
LGTM. Thank you @kskewes for the work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1202