This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Expose --conntrack-max-per-core kube-proxy flag#1187
Merged
Conversation
invidian
force-pushed
the
invidian/conntrack
branch
3 times, most recently
from
68aa5ca to
b24a57c
Compare
surajssd
suggested changes
Nov 19, 2020
| - --proxy-mode=iptables | ||
| - --metrics-bind-address=$(HOST_IP) | ||
| - --healthz-bind-address=$(HOST_IP) | ||
| {{- if not (eq (int .Values.kubeProxy.conntrackMaxPerCore) 32768) }} |
Member
There was a problem hiding this comment.
We can get rid of this if block if we provide the same default value as whatever is set in the node right now.
Member
Author
There was a problem hiding this comment.
This line allows kube-proxy to steer the default value, allowing us to update it asynchronously if it ever changes.
It also reduces final manifest size, I don't see a value in specifying the flag which is exactly the same as default value. I'd prefer to keep it.
assets/terraform-modules/aws/flatcar-linux/kubernetes/variables.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/packet/flatcar-linux/kubernetes/variables.tf
Outdated
Show resolved
Hide resolved
invidian
force-pushed
the
invidian/conntrack
branch
from
b24a57c to
8d45554
Compare
Member
|
@invidian I can't review this right now due to load, sorry. Please assign someone else. |
invidian
force-pushed
the
invidian/conntrack
branch
2 times, most recently
from
62f1d0a to
03cfea2
Compare
knrt10
reviewed
Nov 24, 2020
knrt10
suggested changes
Nov 24, 2020
Contributor
knrt10
left a comment
knrt10
left a comment
There was a problem hiding this comment.
Nice work, some minor suggestions
surajssd
previously approved these changes
Nov 24, 2020
invidian
force-pushed
the
invidian/conntrack
branch
from
03cfea2 to
5038d83
Compare
Member
Author
invidian
force-pushed
the
invidian/conntrack
branch
from
5038d83 to
a28c642
Compare
knrt10
previously approved these changes
Nov 24, 2020
iaguis
suggested changes
Nov 24, 2020
assets/terraform-modules/aws/flatcar-linux/kubernetes/variables.tf
Outdated
Show resolved
Hide resolved
invidian
force-pushed
the
invidian/conntrack
branch
from
a28c642 to
2b5583a
Compare
Member
Author
|
Also added configuration validation rules and unit tests for that. |
Contributor
|
@invidian can you please check the CI errors? |
Member
Author
|
@knrt10 they were caused by Docker Hub limits, which should be now resolves, so I restarted them. |
knrt10
previously approved these changes
Nov 27, 2020
invidian
force-pushed
the
invidian/conntrack
branch
from
2b5583a to
6403492
Compare
surajssd
previously approved these changes
Nov 27, 2020
invidian
force-pushed
the
invidian/conntrack
branch
from
6403492 to
cbd94cf
Compare
surajssd
previously approved these changes
Dec 1, 2020
Contributor
|
Have to re-run the tests again after rebasing for bare metal to pass 😢 |
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
This commit exposes --conntrack-max-per-core kube-proxy flag in kubernetes Helm chart and adds required plumbing to expose it to the user using HCL. It also adds sample usage to CI configuration and e2e tests to verify that settings are properly applied. Closes #1081 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/conntrack
branch
from
cbd94cf to
ebf81dd
Compare
knrt10
approved these changes
Dec 1, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes --conntrack-max-per-core kube-proxy flag in
kubernetes Helm chart and adds required plumbing to expose it to the
user using HCL.
It also adds sample usage to CI configuration and e2e tests to verify
that settings are properly applied.
Closes #1081
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io