This repository was archived by the owner on Jun 29, 2022. It is now read-only.
Add check for multiple release in Namespace#1093
Merged
Conversation
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
eb450f7 to
3e65cfa
Compare
invidian
suggested changes
Oct 19, 2020
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
846ddb5 to
645f86e
Compare
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
645f86e to
b94acaf
Compare
invidian
suggested changes
Oct 19, 2020
Member
invidian
left a comment
invidian
left a comment
There was a problem hiding this comment.
LGTM, but I would add tests for it.
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
b562caf to
55f3733
Compare
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
55f3733 to
0372040
Compare
invidian
previously approved these changes
Oct 19, 2020
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
0372040 to
945b4b5
Compare
added 4 commits
October 21, 2020 11:52
User should know that before deleting a component that other helm release exists in a namespace. closes: #1077 Signed-off-by: knrt10 <kautilya@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
Headlamp is installed in `lokomotive-system` so deleting it along with namespace should throw error. Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/component-delete-namespace-multiple-releases
branch
from
945b4b5 to
d808ec0
Compare
invidian
approved these changes
Oct 21, 2020
knrt10
deleted the
knrt10/component-delete-namespace-multiple-releases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User should know that before deleting a component that other helm
release exists in a namespace.
closes: #1077
Signed-off-by: knrt10 kautilya@kinvolk.io