Fix includes #27
Fix includes #27
Conversation
WalkthroughThe recent changes primarily streamline the CMake configuration for building Google Test and Google Mock. Paths have been adjusted from Windows-style to Unix-style, enhancing portability across environments. Additionally, key flags like pthread support have been enabled, ensuring better consistency and performance. The updates simplify maintenance and clarify the build process without altering existing functionalities. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CMake
participant GoogleTest
participant GoogleMock
User->>CMake: Initiate Build
CMake->>GoogleTest: Configure Paths
CMake->>GoogleMock: Configure Paths
CMake->>GoogleTest: Enable Pthread Support
CMake->>GoogleMock: Enable Pthread Support
GoogleTest->>User: Build Complete
GoogleMock->>User: Build Complete
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- CMakeLists.txt (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/GTestConfig.cmake (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/GTestConfigVersion.cmake (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/gmock.pc (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/gmock_main.pc (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/gtest.pc (1 hunks)
- contrib/googletest-1.10.x/googletest/generated/gtest_main.pc (1 hunks)
Files skipped from review due to trivial changes (3)
- CMakeLists.txt
- contrib/googletest-1.10.x/googletest/generated/gmock.pc
- contrib/googletest-1.10.x/googletest/generated/gmock_main.pc
Additional comments not posted (7)
contrib/googletest-1.10.x/googletest/generated/gtest.pc (3)
1-1: LGTM! Thelibdirchange improves portability.The update from a Windows-specific path to a Unix-style path enhances the portability across Unix-like environments.
2-2: LGTM! Theincludedirchange improves portability.The update from a Windows-specific path to a Unix-style path enhances the portability across Unix-like environments.
9-9: LGTM! Enabling pthread support is beneficial.The update to enable pthread support can improve performance and consistency in multi-threaded environments.
contrib/googletest-1.10.x/googletest/generated/gtest_main.pc (3)
1-1: LGTM! Thelibdirchange improves portability.The update from a Windows-specific path to a Unix-style path enhances the portability across Unix-like environments.
2-2: LGTM! Theincludedirchange improves portability.The update from a Windows-specific path to a Unix-style path enhances the portability across Unix-like environments.
10-10: LGTM! Enabling pthread support is beneficial.The update to enable pthread support can improve performance and consistency in multi-threaded environments.
contrib/googletest-1.10.x/googletest/generated/GTestConfig.cmake (1)
27-30: LGTM! Ensuring threading support is always preferred.The change to make the conditional statement always evaluate to true ensures that threading support is always preferred, which can improve consistency in the build process.
| # if the installed project requested no architecture check, don't perform the check | ||
| if("FALSE") | ||
| return() | ||
| endif() |
There was a problem hiding this comment.
Fix the hardcoded condition to make it configurable.
The condition if("FALSE") is hardcoded to always skip the architecture check. This should likely be based on a variable or configuration option to make it configurable.
- if("FALSE")
+ if(NOT DEFINED NO_ARCHITECTURE_CHECK OR NO_ARCHITECTURE_CHECK)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # if the installed project requested no architecture check, don't perform the check | |
| if("FALSE") | |
| return() | |
| endif() | |
| # if the installed project requested no architecture check, don't perform the check | |
| if(NOT DEFINED NO_ARCHITECTURE_CHECK OR NO_ARCHITECTURE_CHECK) | |
| return() | |
| endif() |
Summary by CodeRabbit
New Features
Bug Fixes
Chores