Enable linkage

[kimkulling]

• Add export tags to memutils

Summary by CodeRabbit

• New Features

  • Enhanced MemUtils class with additional memory operation functions (alignPtr and isAligned).
  • Included export declarations for improved interoperability.

• Improvements

  • Added default constructors and destructors for MemUtils class to streamline object initialization and cleanup.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The MemUtils class in MemUtils.h has been enhanced with export declarations and new member functions for memory operations, including alignPtr and isAligned. Additionally, default constructors and destructors have been added to the class, improving its utility and export capabilities.

Changes

File	Summary of Changes
include/cppcore/Memory/MemUtils.h	The MemUtils class now has export declaration, new functions (alignPtr, isAligned), and defaults for constructors and destructors.

Poem

In the land of code, a change did sprout,
MemUtils got new tools, there's no doubt.
Aligned and tidy, pointers now stand,
Thanks to functions, crafted by hand.
Constructors and destructors, all set in place,
A memory marvel, with elegance and grace.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 508da92 and 3fbc204.

Files selected for processing (1)

• include/cppcore/Memory/MemUtils.h (2 hunks)

Additional comments not posted (4)

include/cppcore/Memory/MemUtils.h (4)

44-44: Export declaration added for cross-platform compatibility.

The DLL_CPPCORE_EXPORT macro has been correctly added to the class declaration to enable linkage for different platforms.

---

53-53: New member functions and default constructors/destructors added.

The addition of isAligned and alignPtr functions, along with default constructors and destructors, enhances the utility of the class for memory alignment tasks. These additions are consistent with the PR objectives and are well-implemented.

Also applies to: 63-63, 67-67

---

53-60: Review of new member functions for alignment.

The isAligned and alignPtr functions are crucial for memory alignment checks and adjustments. The implementation appears correct and efficient, using bitwise operations for alignment checks and adjustments.

---

63-67: Default constructor and destructor.

The use of default constructors and destructors is a good practice in modern C++ to ensure that the compiler-generated versions are appropriate, which is especially useful for classes that do not manage resources directly.