Skip to content

fix: restrict page scroll and allow column-only scrolling#14360

Merged
MilosPaunovic merged 2 commits into
kestra-io:developfrom
Iam-Karan-Suresh:fix-output-view-scroll
Jan 30, 2026
Merged

fix: restrict page scroll and allow column-only scrolling#14360
MilosPaunovic merged 2 commits into
kestra-io:developfrom
Iam-Karan-Suresh:fix-output-view-scroll

Conversation

@Iam-Karan-Suresh

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR improves the scrolling behavior in the Outputs view.

Currently, the entire page is scrollable even though each column already has its own scroll.
This causes an issue where scrolling the page can cut off or hide the selected outputs.

This change limits scrolling at the page level and ensures that only the individual columns
handle scrolling, providing a more stable and predictable UI experience.

Why is this needed?

How was this tested?

  • Opened Outputs view with multiple outputs
  • Verified that page scroll is restricted
  • Confirmed each column scrolls independently without layout break

Related Issue

Fixes #14343

@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Jan 30, 2026
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors labels Jan 30, 2026
@MilosPaunovic

Copy link
Copy Markdown
Member

@Iam-Karan-Suresh, could you share a quick screen recording showing the current behavior?

@MilosPaunovic MilosPaunovic moved this from To review to On hold in Pull Requests Jan 30, 2026
@Iam-Karan-Suresh

Iam-Karan-Suresh commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Hey @MilosPaunovic

I’m facing an issue while testing the given YAML flow.
At line 6, I’m getting the following validation error:

Validation error: Invalid type: io.kestra.plugin.scripts.shell.Commands

Could you please help me with the correct task type or how to fix this so I can test the flow locally?
image

Thank you! 🙏

@MilosPaunovic

Copy link
Copy Markdown
Member

So you've raised this PR without testing it locally?

Thanks, but it will be closed.

@github-project-automation github-project-automation Bot moved this from On hold to Done in Pull Requests Jan 30, 2026
@Iam-Karan-Suresh

Copy link
Copy Markdown
Contributor Author

Hey @MilosPaunovic,

I apologize for the miscommunication earlier. Let me clarify what happened:

What I did:

  1. I made the changes locally (adding maximized: true and noOverflow: true)
  2. I tested the visual behavior of the outputs view with these changes
  3. I created the PR based on those tests

The confusion:
When you asked me to test with the YAML flow from the issue, I encountered validation errors with the Python script example. I wanted to test it thoroughly with that specific flow before confirming, which is why I asked for help.

However, I was able to test with this alternative flow:

id: test_outputs_scroll
namespace: dev.testing
tasks:
  - id: generate_outputs
    type: io.kestra.plugin.core.log.Log
    message: "Generating test outputs"
  - id: create_multiple_outputs
    type: io.kestra.plugin.core.flow.Sequential
    tasks:
      - id: output_1
        type: io.kestra.plugin.core.debug.Return
        format: |
          {
            "data": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
            "message": "First output set"
          }
      # ... (additional outputs)

Screen recording showing the behavior:
[Screencast.webm](https://github.com/user-attachments/assets/ed7e5b54-a369-482f-988e-b151548e5f90)

I should have been clearer from the start. I did test before creating the PR - the miscommunication was around which specific YAML flow I used for testing.

If you'd like me to test with any other specific scenario or if the changes need adjustment, I'm happy to iterate on this.

Thank you for your patience! 🙏

@MilosPaunovic

Copy link
Copy Markdown
Member

So, in your video, what are you trying to scroll as there are no enough items?

@Iam-Karan-Suresh

Iam-Karan-Suresh commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

You're absolutely right - my test didn't have enough items to properly demonstrate the scrolling behavior. I was trying to test with the YAML example provided in the original issue (#14343), but I'm encountering validation errors with the Python plugin that's preventing me from running it locally:
Validation error: Invalid type: io.kestra.plugin.scripts.python.Script

Could you help me with either:

How to properly install the required plugins to run the original test case, or
An alternative YAML flow that generates enough output items to test the scrolling behavior?

I want to make sure I can replicate the exact scenario from the issue before confirming the fix works correctly.
Thank you @MilosPaunovic !

@MilosPaunovic MilosPaunovic reopened this Jan 30, 2026
@github-project-automation github-project-automation Bot moved this from Done to To review in Pull Requests Jan 30, 2026
@MilosPaunovic MilosPaunovic requested review from MilosPaunovic and removed request for Piyush-r-bhaskar January 30, 2026 08:33
@MilosPaunovic MilosPaunovic merged commit c865a9f into kestra-io:develop Jan 30, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Jan 30, 2026
@Iam-Karan-Suresh

Copy link
Copy Markdown
Contributor Author

Thank you @MilosPaunovic! I appreciate your patience and guidance through this process. I'll make sure to have a complete test environment set up for future contributions. 🙏

MilosPaunovic added a commit that referenced this pull request Feb 11, 2026
…endent scroll (#14360)

Closes #14343.

Co-authored-by: Miloš Paunović <paun992@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Outputs View] Entire page is able to scroll despite columns being able to scroll independently

2 participants