fix(ui): remove deleted flow revision from dropdown immediately#14096
Merged
Piyush-r-bhaskar merged 1 commit intoJan 12, 2026
Merged
Conversation
MilosPaunovic
added
area/frontend
Piyush-r-bhaskar
force-pushed
the
fix/revision-dropdown-not-updating
branch
from
89f9dd9 to
0b9aed4
Compare
Piyush-r-bhaskar
force-pushed
the
fix/revision-dropdown-not-updating
branch
from
0b9aed4 to
29d4f76
Compare
Contributor
Author
|
Thanks for the review @MilosPaunovic @Piyush-r-bhaskar — appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Fixes a frontend reactivity issue where deleting a flow revision required a full page refresh for the UI to update.
This PR updates
FlowRevisions.vueto bind directly to the reactiveflowStore.revisionsstate instead of maintaining a local static snapshot. As a result, the revisions dropdown now stays in sync automatically when revisions are added or removed.Additionally, the
Revisionsdropdown logic now re-synchronizes correctly when the revisions list length changes.🔗 Related Issue
closes #14054
🎨 Frontend Checklist
npm run build)npm run test:e2e)📝 Additional Notes
Technical Details
The root cause was a broken reactivity chain:
FlowRevisions.vuewas fetching revisions from the store but copying them into a localref.Changes made:
FlowRevisions.vue
refwithcomputed(() => flowStore.revisions)to ensure live, reactive updates from the store.Revisions.vue
props.revisions.lengthto re-align selected indices when revisions are removed.This ensures a single source of truth and prevents UI desynchronization without requiring a page refresh.
Screencast.from.2026-01-10.01-03-18.webm