bpf/verifier: factor BPF_F_TEST_RND_HI32 flag check out of opt_subreg_zext_lo32_rnd_hi32 #5589
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
…_zext_lo32_rnd_hi32 BPF programs can be loaded with the BPF_F_TEST_RND_HI32 flag to instruct the verifier to randomize the high 32 bits of a register being used as a subregister. This is done in the opt_subreg_zext_lo32_rnd_hi32 pass that scans the BPF program instruction by instruction, regardless of whether the flag is set or not, and testing the flag on every iteration. However, the flag is not modified at verification time, and the function is a no-op if it is unset. Gate the randomization pass behind a single flag check instead of testing the flag in the main loop of the pass. Signed-off-by: Emil Tsalapatis <[email protected]>
|
Upstream branch: ea2aecd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf/verifier: factor BPF_F_TEST_RND_HI32 flag check out of opt_subreg_zext_lo32_rnd_hi32
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=981641