Skip to content

Progress bar now handles steps_per_execution. #21422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

hertschuh
Copy link
Collaborator

Progress bar would always report the starting batch + 1 at the end of the batch. Now it takes into account steps_per_execution for the last batch reported.

Fixes #20861

Progress bar would always report the starting batch + 1 at the end of the batch. Now it takes into account `steps_per_execution` for the last batch reported.

Fixes keras-team#20861
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (3a11132) to head (dda0634).

Files with missing lines Patch % Lines
keras/src/backend/openvino/trainer.py 0.00% 3 Missing ⚠️
keras/src/backend/jax/trainer.py 90.00% 0 Missing and 1 partial ⚠️
keras/src/backend/numpy/trainer.py 85.71% 0 Missing and 1 partial ⚠️
keras/src/backend/tensorflow/trainer.py 90.00% 0 Missing and 1 partial ⚠️
keras/src/trainers/trainer.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21422   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         565      565           
  Lines       55222    55222           
  Branches     8609     8609           
=======================================
  Hits        45683    45683           
  Misses       7428     7428           
  Partials     2111     2111           
Flag Coverage Δ
keras 82.53% <85.10%> (ø)
keras-jax 63.33% <31.91%> (ø)
keras-numpy 58.53% <27.65%> (ø)
keras-openvino 33.79% <0.00%> (ø)
keras-tensorflow 63.74% <31.91%> (ø)
keras-torch 63.37% <31.91%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Haven't tested out the progbar or anything like that.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 26, 2025
@hertschuh hertschuh merged commit df58ec9 into keras-team:master Jun 26, 2025
11 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Jun 26, 2025
@hertschuh hertschuh deleted the progress_step_count branch June 26, 2025 16:51
Mohamed-Ashraf273 pushed a commit to Mohamed-Ashraf273/keras that referenced this pull request Jul 8, 2025
Progress bar would always report the starting batch + 1 at the end of the batch. Now it takes into account `steps_per_execution` for the last batch reported.

Fixes keras-team#20861
kharshith-k pushed a commit to kharshith-k/keras that referenced this pull request Jul 23, 2025
Progress bar would always report the starting batch + 1 at the end of the batch. Now it takes into account `steps_per_execution` for the last batch reported.

Fixes keras-team#20861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar showing wrong step number
5 participants