Skip to content

[OpenVINO Backend] support comparison ops (>, <, <=, >=, ==, !=) for OpenVINOKerasTensor #21348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mohamed-Ashraf273
Copy link
Contributor

Hi @rkazants ,
Supporting comparison ops (>, <, <=, >=, ==, !=) for OpenVINOKerasTensor, which is needed for my GSoC project.
Could you please review it?

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (86b4b40) to head (1ac84f5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 20.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21348      +/-   ##
==========================================
- Coverage   82.67%   82.64%   -0.04%     
==========================================
  Files         565      565              
  Lines       54835    54865      +30     
  Branches     8513     8513              
==========================================
+ Hits        45337    45343       +6     
- Misses       7413     7437      +24     
  Partials     2085     2085              
Flag Coverage Δ
keras 82.45% <20.00%> (-0.04%) ⬇️
keras-jax 63.59% <0.00%> (-0.04%) ⬇️
keras-numpy 58.74% <0.00%> (-0.04%) ⬇️
keras-openvino 33.11% <20.00%> (-0.01%) ⬇️
keras-tensorflow 63.98% <0.00%> (-0.04%) ⬇️
keras-torch 63.62% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 4, 2025
@fchollet
Copy link
Collaborator

fchollet commented Jun 4, 2025

This branch has conflicts that must be resolved

Please fix merge conflicts!

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Jun 4, 2025
@Mohamed-Ashraf273
Copy link
Contributor Author

This branch has conflicts that must be resolved

Please fix merge conflicts!

@fchollet
Done, Conflicts have been resolved!

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 4, 2025
@fchollet fchollet merged commit a0949a8 into keras-team:master Jun 4, 2025
10 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Jun 4, 2025
@Mohamed-Ashraf273 Mohamed-Ashraf273 deleted the support_comparison_operations branch June 5, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants