Initialize random seed for distributed models. #21261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21261 +/- ##
==========================================
- Coverage 82.55% 82.54% -0.01%
==========================================
Files 564 564
Lines 54629 54651 +22
Branches 8493 8496 +3
==========================================
+ Hits 45097 45114 +17
- Misses 7442 7445 +3
- Partials 2090 2092 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Keep track of a `global_random_seed`, and ensure it is set when initializing `keras.distribution.initialize(...)`. In multi-host processes in JAX, all processes require consistent random number generation. Otherwise, initializers on different hosts would produce inconsistent values, resulting in both compilation and runtime failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of a
global_random_seed, and ensure it is set when initializingkeras.distribution.initialize(...).In multi-host processes in JAX, all processes require consistent random number generation. Otherwise, initializers on different hosts would produce inconsistent values, resulting in both compilation and runtime failures.