Implement dot function in OpenVINO backend for Keras #20987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rkazants
reviewed
Mar 5, 2025
rkazants
reviewed
Mar 5, 2025
keras/src/backend/openvino/numpy.py
Outdated
| if len(x.shape) == 2 and len(y.shape) == 1: | ||
| y = ov_opset.unsqueeze(y, [1]) | ||
| return ov_to_keras_type(ov_opset.squeeze(ov_opset.matmul(x, y), [1])) | ||
| return ov_to_keras_type(ov_opset.matmul(x, y)) |
rkazants
reviewed
Mar 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20987 +/- ##
==========================================
- Coverage 82.45% 80.12% -2.33%
==========================================
Files 562 562
Lines 53303 53331 +28
Branches 8257 8264 +7
==========================================
- Hits 43949 42733 -1216
- Misses 7338 8633 +1295
+ Partials 2016 1965 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rkazants
reviewed
Mar 6, 2025
rkazants
reviewed
Mar 6, 2025
rkazants
reviewed
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Implemented dot function in numpy.py inside the OpenVINO backend.
Removed the corresponding entry from excluded_concrete_tests.txt.
create pytest.ini in root dir
Testing:
Ran pytest to verify that the implementation works correctly.
Let me know if any additional modifications or refinements are needed.
@rkazants, please review.