Skip to content

Conversation

grasskin
Copy link
Member

@grasskin grasskin commented Nov 9, 2023

No description provided.

Co-authored-by: Tirth Patel <[email protected]>
Copy link
Contributor

@tirthasheshpatel tirthasheshpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @grasskin!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4feb16) 78.95% compared to head (8ab5cdf) 72.85%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18756      +/-   ##
==========================================
- Coverage   78.95%   72.85%   -6.11%     
==========================================
  Files         336      336              
  Lines       34023    34026       +3     
  Branches     6660     6660              
==========================================
- Hits        26862    24788    -2074     
- Misses       5582     7695    +2113     
+ Partials     1579     1543      -36     
Flag Coverage Δ
keras 72.78% <100.00%> (-6.06%) ⬇️
keras-jax 61.75% <100.00%> (+<0.01%) ⬆️
keras-numpy 56.25% <100.00%> (+0.02%) ⬆️
keras-tensorflow ?
keras-torch 64.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keras/ops/core.py 74.87% <100.00%> (+0.38%) ⬆️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Nov 10, 2023
@divyashreepathihalli
Copy link
Collaborator

Thanks @grasskin for adding this!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 10, 2023
@fchollet fchollet merged commit 5999db2 into keras-team:master Nov 11, 2023
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

7 participants