Softkomik(ID): Add support manga/manhwa with login required#14499
Open
ar21-jh wants to merge 7 commits intokeiyoushi:mainfrom
Open
Softkomik(ID): Add support manga/manhwa with login required#14499ar21-jh wants to merge 7 commits intokeiyoushi:mainfrom
ar21-jh wants to merge 7 commits intokeiyoushi:mainfrom
Conversation
vetleledaal
reviewed
Apr 4, 2026
| ) | ||
|
|
||
| @Serializable | ||
| data class BearerTokenDto( |
Contributor
There was a problem hiding this comment.
Don't use data class
Suggested change
| data class BearerTokenDto( | |
| class BearerTokenDto( |
While you are following the pattern already used in this file, it would be better to update those to be regular classes too.
| override fun pageListRequest(chapter: SChapter): Request = GET("$baseUrl${chapter.url}", rscHeaders) | ||
|
|
||
| override fun pageListParse(response: Response): List<Page> { | ||
| val isRequiredLogin = response.request.url.toString().contains(requiredLoginSuffix) |
Contributor
There was a problem hiding this comment.
Check against HttpUrl.fragment instead.
Comment on lines
+421
to
+423
| wv.settings.javaScriptEnabled = true | ||
| wv.settings.domStorageEnabled = true | ||
| wv.settings.userAgentString = headers["User-Agent"] |
Contributor
Author
|
Their session logic keeps changing every time I fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension