add missing isNsfw in build.gradle files#14481
Open
luigidotmoe wants to merge 6 commits intokeiyoushi:mainfrom
Open
add missing isNsfw in build.gradle files#14481luigidotmoe wants to merge 6 commits intokeiyoushi:mainfrom
luigidotmoe wants to merge 6 commits intokeiyoushi:mainfrom
Conversation
vetleledaal
previously approved these changes
Apr 3, 2026
Contributor
(still need
|
Contributor
Author
|
Known
These include :
I’ve set a reminder to revisit these at a later date, if no one else addresses them first |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
also change the contributor.md regarding isNsfw which is no longer optional |
AwkwardPeak7
reviewed
Apr 4, 2026
Contributor
Author
|
CI will fail due to #14524 |
vetleledaal
reviewed
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of an effort to standardize the codebase
Bumped only false negatives where I was able to find NSFW content in under a few minutes; some false negatives may still exist
There are still 30ish files with undefined isNsfw values due to various reasons atm
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension