Skip to content

add missing isNsfw in build.gradle files#14481

Open
luigidotmoe wants to merge 6 commits intokeiyoushi:mainfrom
luigidotmoe:isnsfw
Open

add missing isNsfw in build.gradle files#14481
luigidotmoe wants to merge 6 commits intokeiyoushi:mainfrom
luigidotmoe:isnsfw

Conversation

@luigidotmoe
Copy link
Copy Markdown
Contributor

Part of an effort to standardize the codebase
Bumped only false negatives where I was able to find NSFW content in under a few minutes; some false negatives may still exist
There are still 30ish files with undefined isNsfw values due to various reasons atm

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@luigidotmoe luigidotmoe requested a review from stevenyomi as a code owner April 3, 2026 11:44
vetleledaal
vetleledaal previously approved these changes Apr 3, 2026
@darwin-256
Copy link
Copy Markdown
Contributor

(still need isNsfw added):


src/all/

  • cubari/build.gradle
  • foolslidecustomizable/build.gradle

src/ar/

  • shqqaa/build.gradle

src/en/

  • batcave/build.gradle
  • madokami/build.gradle
  • monochromecustom/build.gradle
  • rainofsnow/build.gradle
  • ryumanga/build.gradle
  • shootingstarscans/build.gradle
  • warforrayuba/build.gradle
  • webcomics/build.gradle
  • zeroscans/build.gradle

src/es/

  • leercapitulo/build.gradle

src/fr/

  • japscan/build.gradle
  • mangakawaii/build.gradle

src/id/

  • ngomik/build.gradle
  • shinigami/build.gradle

src/ko/

  • toonkor/build.gradle

src/pt/

  • mangalivre/build.gradle
  • randomscan/build.gradle
  • saikaiscan/build.gradle

src/ru/

  • comx/build.gradle

src/tr/

  • eldermanga/build.gradle
  • gaiatoon/build.gradle
  • mangaship/build.gradle
  • tenshimanga/build.gradle
  • uzaymanga/build.gradle

src/vi/

  • doctruyen5s/build.gradle
  • truyenqq/build.gradle

src/zh/

  • baimangu/build.gradle
  • comicabc/build.gradle
  • manhuaren/build.gradle
  • miaoqu/build.gradle

Total missing files: 34

@luigidotmoe
Copy link
Copy Markdown
Contributor Author

Known

There are still 30ish files with undefined isNsfw values due to various reasons atm

These include :

  • Down (at least when I tried to check)
  • Requires an account
  • Geo-blocked
  • CF
  • Unfriendly UI, couldn't confirm status without spending too much time (it was already quite time consuming)
  • Requires an app (IIRC, zh sources)

I’ve set a reminder to revisit these at a later date, if no one else addresses them first

@FiorenMas

This comment was marked as outdated.

@MuhamadSyabitHidayattulloh
Copy link
Copy Markdown
Contributor

also change the contributor.md regarding isNsfw which is no longer optional

@luigidotmoe luigidotmoe requested a review from vetleledaal April 4, 2026 18:34
@luigidotmoe
Copy link
Copy Markdown
Contributor Author

CI will fail due to #14524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants